Closed hsanjuan closed 5 years ago
:exclamation: No coverage uploaded for pull request base (
master@dba592a
). Click here to learn what that means. The diff coverage is73.52%
.
@@ Coverage Diff @@
## master #3 +/- ##
=========================================
Coverage ? 85.49%
=========================================
Files ? 6
Lines ? 448
Branches ? 0
=========================================
Hits ? 383
Misses ? 33
Partials ? 32
Impacted Files | Coverage Δ | |
---|---|---|
sp.go | 100% <100%> (ø) |
|
record_payload.go | 100% <100%> (ø) |
|
byte_utils.go | 87.5% <50%> (ø) |
|
message.go | 78.49% <60%> (ø) |
|
record.go | 78.37% <69.23%> (ø) |
|
record_chunk.go | 93.28% <90.9%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update dba592a...80c8f81. Read the comment docs.
@hsanjuan, well done, new helpers are awesome. Could I ask you to add also NewEmptyRecord helper? Think it be useful too.
cc @taglme
This should fix a bunch of issues and adds SmartPoster support (with helpers). From example:
Seems to work on my phone.