hsbijarniya / image_editor_plus

Flutter Image Editor Plugin with simple, easy support for image editing using Paints, Text, Filters, Emoji and Sticker like stories.
MIT License
104 stars 103 forks source link

Fixed issues #19

Closed DizzasTeR closed 1 year ago

DizzasTeR commented 2 years ago

Attempted to fix following:

About issue 12 and 13: I could not reproduce the issue before so not sure if they actually got fixed

A few other fixes including UI fixes and text color not updating with slider

I also forced a few theme colors (mainly dark) to stop the entire mess of colors mixing up

Most dependencies were updated

Stefi16 commented 2 years ago

Hey, I recieve the following errors after running the code: ../Downloads/flutter/.pub-cache/git/image_editor_plus-25a3815edb84770bf6a854ec20459485f401dae9/lib/image_editor_plus.dart:1290:38: Error: The method 'build' isn't defined for the class 'ColorFilterGenerator'.

DizzasTeR commented 2 years ago

Not sure why you're getting that, I changed the dependency package to my fork and it works fine. If it only happens when using my fork then I'll take a look

Stefi16 commented 2 years ago

Yes it happens only using your forked repository

DizzasTeR commented 2 years ago

Yes it happens only using your forked repository

Hmm, okay I'll see whats wrong then, maybe it works for me because of some cache thing, i'll try on a fresh project and let you know

DizzasTeR commented 2 years ago

@Stefi16 Whats your compiledSdkVersion in /android/app/build.gradle

Stefi16 commented 2 years ago

@DizzasTeR 31

DizzasTeR commented 2 years ago

@Stefi16 Pushed some changes, pub get and pub upgrade and give it a go. Also you might need compiledSdkVersion of 33 and minSdkVersion 21 for some dependencies to work (Concluded this by starting a fresh project, and adding this package as dependency only)

Stefi16 commented 2 years ago

Okay will test it thank you.

volodymyr-perveev commented 1 year ago

merge plese)

hsbijarniya commented 1 year ago

@DizzasTeR please update conflicting files.