search

hsdeckviewer / hsdeckviewer.github.io

A simple viewer for multiple Hearthstone decks used for sharing deck lineups.
https://hsdeckviewer.github.io
11 stars 3 forks source link

Highlander deckcodes with Custom name don't get shown #7

Closed omgfrost closed 4 years ago

omgfrost commented 4 years ago

Hello, according to this: https://github.com/oliverfei/HearthstoneDeckViewer/pull/5 this format for highlander deckcode with custom name won't work:

### EGOWAFFLE HL HUNTER
# Format: Standard
# Year of the Phoenix
#
AAECAR8etQPhBIoHlwjbCfyjA+SkA6alA4SnA4qtA4utA46tA/muA/yvA/6vA4ewA+ewA/+wA4KxA4WxA4exA9iyA6+3A4O5A6K5A/+6A9a+A9e+A96+A8PMAwAA
#
# To use this deck, copy it to your clipboard and create a new deck in Hearthstone

I tried also with this format which usually work with non highlander decks:

### DECKNAME
#
DECKCODE
#
# To use this deck, copy it to your clipboard and create a new deck in Hearthstone

and it also not working with HL deckcodes. Is it because HL deckcodes are too long or something? Thanks in advance

devmaxxing commented 4 years ago

The HL deckcode wasn't being extracted as it wasn't recognized by the regex pattern I used for finding base64 strings. I've since updated how the site extracts the deckcode to just take the longest word as a quick fix so this should be working now,

devmaxxing commented 4 years ago

@omgfrost closing this for now as per my previous comment. Feel free to reopen if you're still having problems with this.