hsdn / tera-guide

[MT: The Dream (Menma's TERA) / Asura Tera / Starscape / 여명] The dungeon guide for patch v100.02 (x64) and v92.04. Display hints on screen and drawing zones of bosses attacks and mechanics. Модуль подсказок по данжам, вывод сообщений в чат или на экран, а также отрисовка зон атак боссов и механик.
https://discord.gg/sJzRJhtwWX
MIT License
52 stars 17 forks source link

Did it ever occur to you to add the Spanish language? #31

Closed Loliconera closed 4 years ago

Loliconera commented 4 years ago

For example, in my case, I have to translate the entire module from the English / Russian language to the native language, which for me is Spanish.

I recorded some videos where you can see the translation into Spanish made by me. https://www.youtube.com/watch?v=VxqPmgbf4dw&t=97s&ab_channel=GustavoSicha https://www.youtube.com/watch?v=EnG2cTIPJTc&t=4s&ab_channel=GustavoSicha

justkeepquiet commented 4 years ago

Hi, Our team does not have people who know Spanish. You can translate the all files yourself, and if possible, we will add support for this language. We will also need to add feature for a manual language selection, since Spanish is not supported in Tera client by default.

Loliconera commented 4 years ago

uhm yeah you're right

Loliconera commented 4 years ago

here is the mod with the spanish translation, only a few dungeons have been translated into spanish

Dungeons Soportados -Velik's Sanctuary -Red Refuge <- Español -RK-9 Kennel <- Español -RK-9 Kennel (Rampaging)
-Antaroth's Abyss (Hard) -Grotto of Lost Souls (Hard) -Bahaar's Sanctum -Gossamer Vault (Hard) -Akalath Quarantine <- Español -Sea of Honor <- Español -Corrupted Skynest <- Español -Corrupted Skynest (Hard) -Draakon Arena -Draakon Arena (Hard) -Forbidden Arena [Hagufna] <- Español -Forbidden Arena [Undying Warlord] -Forbidden Arena [Nightmare Undying Warlord] https://drive.google.com/file/d/1wiD4KfDGzv3tq8u7GqNwaLE7zLLNeASQ/view?usp=sharing

Multarix commented 4 years ago

It would be easier to upload your modifications to github so we don't have to download them directly... But as for changing the language manually, it could be done somewhat easily by adding a language selection via the config file with a few changes. Eg a config setting that is by default set to "auto" but if set to Spanish, English, Russian etc it uses that.

Loliconera commented 4 years ago

I have never tried to upload the modded tera guide (hsdn) module to Spanish to GitHub

Multarix commented 4 years ago

That's no problem, git/ github can be a bit confusing so I'm not asking you to do it, just letting you know as it allows us to look over code/ translations without having to download anything.

I'm also not in charge of making any choices for what gets added to this guide or not, so the end choice it's not up to me.

Loliconera commented 4 years ago

I will try to make a copy of the tera guide (hsdn) to the github of my personal account and translate it into Spanish

justkeepquiet commented 4 years ago

But as for changing the language manually, it could be done somewhat easily by adding a language selection via the config file with a few changes. Eg a config setting that is by default set to "auto" but if set to Spanish, English, Russian etc it uses that.

@Multarix, this feature is added in latest updates.

We've also added automatic loading of dungeon names from Tera client, so no names translation is required.

justkeepquiet commented 4 years ago

@Loliconera, For adding a Spanish language to guide files, you need to use a "message_ES" keys instead of "message" (the English translation not be removed). To apply Spanish language to guides, please update module to latest version (you can just create a fork now) and set the parameter language to es in your config.json after Toolbox restart.

Also you can add Spanish translation for module GUI and other messages in the index.js file (see translation object constant).

justkeepquiet commented 4 years ago

We have done work on the simplest possible integration of any language, including non-standard (for the Tera) languages.

Loliconera commented 4 years ago

Hello, I just made a copy of your module and I modified it to Spanish and uploaded it to my Github profile. Here is the repository https://github.com/Loliconera/tera-guide-spanish

You can look at it if you like, because the truth is I am a bit new to creating repositories in github

justkeepquiet commented 4 years ago

If you finish translating all the files and follow the format suggested above ("message_ES" instead of "message" for Spanish), we can include your work in master branch of the guide. And the index.js will look good.

Loliconera commented 4 years ago

I spent an hour trying to understand what you mean by ("message_ES" instead of "message" for Spanish) until I reviewed a guide to a dungeon and discovered that format haha

justkeepquiet commented 4 years ago

All guides are based on the JSON structure, which describe the necessary mechanics and other reactions in the dungeons. Each such entry can contain a message for the player in several languages.

Different keys are used to separate languages, starting with message_, for example message_RU.

For example, for a Draakon Arena 3102.js dungeon, we can define a single entry as: https://github.com/hsdn/tera-guide/blob/master/guides/3102.js#L13

    "s-3102-1000-107-0": [
        { 
            "type": "text", 
            "sub_type": "message", 
            "message": "Spectral Throw (Bait)", 
            "message_RU": "Спектральный бросок (байт)" 
        }
    ],

Where the text is presented in many languages, given by different keys:
message for English (by default) and message_RU for Russian.

To add a Espanol translation, you need to add a record (idk words, this is just example):

            , "message_ES": "Lanzamiento espectral (cebo)"

To make the object look like this:

    "s-3102-1000-107-0": [
        { 
            "type": "text", 
            "sub_type": "message", 
            "message": "Spectral Throw (Bait)", 
            "message_RU": "Спектральный бросок (байт)",
            "message_ES": "Lanzamiento espectral (cebo)" // <-- added Espanol translation record
        }
    ],

Or single line (variant, like records in the all guide files):

    "s-3102-1000-107-0": [{ "type": "text", "sub_type": "message", "message": "Spectral Throw (Bait)", "message_RU": "Спектральный бросок (байт)", "message_ES": "Lanzamiento espectral (cebo)" }],
Loliconera commented 4 years ago

ok

justkeepquiet commented 4 years ago

You need now to get "clean" files from the latest version of the guide and add your translation with the "message_ES" keys to them.

justkeepquiet commented 4 years ago

Also you can contact with https://github.com/Ana-s2, this person also plans to work on a translation guides into Spanish and Portuguese.

Loliconera commented 4 years ago

ready now if it is working with the message_ES format

Loliconera commented 4 years ago

In this code I don't know how to create a format in Spanish 0: { msgt: "IN", msg: "К НЕМУ" } Corrupted Skynest

justkeepquiet commented 4 years ago

Don't touch it yet. You can write a translation in the comments to it, we will fix it.

Loliconera commented 4 years ago

OK thanks

Loliconera commented 4 years ago

I just added the Spanish translations following the message_ES format

https://github.com/Loliconera/tera-guide-spanish

-Red Refuge <- Español -RK-9 Kennel <- Español -Akalath Quarantine <- Español -Sea of Honor <- Español -Corrupted Skynest <- Español -Forbidden Arena [Hagufna] <- Español

justkeepquiet commented 4 years ago

@Loliconera, we make changes for "msgt" and "msg" keys. Please check https://github.com/hsdn/tera-guide/commit/a588ee8a6c05adcbe8c409d7c3ae100f82b10577. You can use this variant in your translation.

Loliconera commented 4 years ago

Perfect, thanks