search

hse-project / hse

HSE: Heterogeneous-memory storage engine
https://hse-project.github.io
673 stars 65 forks source link

Consolidate CLI output functions #621

Open tristan957 opened 1 year ago

tristan957 commented 1 year ago

It seemed like every tool defined its own syntax() and/or fatal(). By making a single a definition for each in libhse-cli, we can cut down all the redefinitions.

This also has the added benefit of reducing the number of tools needing tools/common.c. Less compilation. Yay!

tristan957 commented 1 year ago

Not in love with output.h, so if someone has a better name I am all for it!

tristan957 commented 1 year ago

A rare PR where I remove lines of code...

alexttx commented 1 year ago

~Last PR. No Mas.~

Changing my mind. Rejecting this PR. This RC is baked. Can't change 45 files hours before QA kicks off a round of tests.

tristan957 commented 1 year ago

Don't really care if it makes it into the rc. Just posting it to be merged eventually.