hseeberger / constructr

Coordinated (etcd, ...) cluster construction for dynamic (cloud, containers) environments
Apache License 2.0
212 stars 37 forks source link

Setting etcd-port via environment #132

Closed ostronom closed 7 years ago

ostronom commented 7 years ago

According to https://github.com/hseeberger/constructr/blob/db0f6297b19abd48e1bf6da148c1bfd0980f3b47/constructr-coordination-etcd/src/main/scala/de/heikoseeberger/constructr/coordination/etcd/EtcdCoordination.scala#L65

the port value in config should be a number, but if you are setting it via $"{?ENV_VAR_NAME}" pattern, it comes as a string. Maybe,

    val port = system.settings.config.getString("constructr.coordination.port").toInt

will help?

ostronom commented 7 years ago

There was a problem with our build server configuration. I am very sorry about this.

hseeberger commented 7 years ago

No worries ;-)