Hi, because of Tecsisa/constructr-consul#49, I think it is necessary to add a close() method to Coordination, in order to perform resource release on system shutdown in a clean, elegant way. An example of such resource cleanup would be destroying the Consul session instead of just relying on TTL.
close() would be invoked by the ConstructrMachine implementation of the onTermination hook.
If this is not useful to etcd, we can just have a dummy implementation of close(), returning something like Future.successful(Done).
Hi, because of Tecsisa/constructr-consul#49, I think it is necessary to add a
close()method toCoordination, in order to perform resource release on system shutdown in a clean, elegant way. An example of such resource cleanup would be destroying the Consul session instead of just relying on TTL.close()would be invoked by theConstructrMachineimplementation of theonTerminationhook.If this is not useful to etcd, we can just have a dummy implementation of
close(), returning something likeFuture.successful(Done).