search

hseeberger / constructr

Coordinated (etcd, ...) cluster construction for dynamic (cloud, containers) environments
Apache License 2.0
212 stars 37 forks source link

Propagate extension failures to user-space (refs #171) #172

Open nick-nachos opened 6 years ago

nick-nachos commented 6 years ago

As discussed in #171 I have removed the actor-system stopping behavior, modernized the ConstructrExtension by switching to the new style of extension implementation and added the ability to hook up event handlers to ConstructR failures, for which I added a couple of tests as well. In the context of this work I also removed the deprecated ActorDSL stuff from the multi-jvm test and replaced it with regular actor creation code, as per akka guidelines.

hseeberger commented 6 years ago

Thanks a lot! I will take a look soon, but not before next week. Apologies for the delay.

nick-nachos commented 6 years ago

No problem at all, we will proceed our experimentation with a local version of our own for the time being. I will also proceed with dealing with the rest of the issues and making the corresponding pull requests so that, hopefully, when you get the time you will have the chance to review them all at once. Cheers!