hsf-training / cpluspluscourse

C++ Course Taught at CERN, from Sebastien Ponce (LHCb)
Apache License 2.0
169 stars 65 forks source link

Implement comments from #428 #508

Closed hageboeck closed 6 months ago

hageboeck commented 8 months ago

This is the implementation of many remarks / suggestions made in #428, such as:

I decided to disregard many comments from #428, because there was no reasonable way to change the slides. These comments referred rather to what we say or questions that the students asked. All the things I did implement are marked with tick boxes, and the things I left out have empty boxes in #428. I don't see a way to do better, so I propose to close the issue after this PR.

Resolves #428

sponce commented 8 months ago

@hageboeck can you rebase so that pdf can be built and we can see the result ?

hageboeck commented 8 months ago

can you rebase so that pdf can be built and we can see the result ?

@sponce The CI completed now.

hageboeck commented 7 months ago

The parts where we couldn't agree are removed now. I think that should be enough now to close #428.