search

hsf-training / hsf-training-cicd-github

An introduction to continuous integration (CI) and continuous deployment (CD) using GitHub Actions
https://hsf-training.github.io/hsf-training-cicd-github/
Other
1 stars 8 forks source link

Remove non-essential containerization material #79

Closed ariostas closed 4 months ago

ariostas commented 4 months ago

I removed most mentions of containerization throughout the material. When introducing compilation and ROOT scripts, I showed how to get ROOT with Conda. However, for the rest of the material, it makes more sense to run on the ROOT Docker images, so I added a brief paragraph mentioning that it's not necessary to know anything about containerization, and that these images can be thought of as a more convenient set of pre-installed software.

I did remove every mention of act since it requires Docker, and it doesn't add much value to the material.

Lastly, I fixed some small issues that were present in the yaml files like outdated action versions, typos, and missing escape sequences.

welcome[bot] commented 4 months ago

Thanks for opening your first pull request here 🚀! If you have any questions, feel free to mention one of the conveners, previous contributors, or attend our weekly meeting (see our homepage). Also, sometimes PRs go unnoticed, so don't hesitate to @mention some of us, if we do not come back to you within a few days.

ariostas commented 4 months ago

I addressed the comments by @goi42, fixed a few small issues that I found while recording the lessons, and removed the old videos. I'll wait until tomorrow to see if there are any more comments and I'll merge the PR.

welcome[bot] commented 4 months ago

Congrats on merging your first pull request 🎉! We greatly appreciate it. You might be eligible to be added to the HSF Training Community page (see the instructions on the page for how to create a profile). If you already have created a profile previously, make sure you're also added to the current year. If this repository features a list of contributors at the bottom of the readme, you might also be eligible to add yourself there.