search

hsf-training / hsf-training-cms-analysis-webpage

Webpage for github.com/hsf-training/hsf-training-cms-analysis
https://hsf-training.github.io/hsf-training-cms-analysis-webpage/
Other
0 stars 3 forks source link

Update links to repository with files and add option to clone the repository #11

Closed amanmdesai closed 2 years ago

amanmdesai commented 2 years ago

Closes #10

welcome[bot] commented 2 years ago

Thanks for opening your first pull request here 🚀! If you have any questions, feel free to mention one of the conveners, previous contributors, or attend our weekly meeting (see our homepage). Also, sometimes PRs go unnoticed, so don't hesitate to @mention some of us, if we do not come back to you within a few days.

klieret commented 2 years ago

Thanks a lot!

Just one quick thing that I've noticed if you do the curl variant, the folder is called differently with suffix -master at the end. Do you think this will impact the rest of the lesson? Should we have a rename step afterwards (either there or for the git command, depending on what is needed?)

amanmdesai commented 2 years ago

Yes indeed I have been thinking about it. It wont impact the lessons. But can make the setup procedure a bit confusing.

There is also some inconsistency in instructions on docker. (its not incorrect but maybe confusing for someone)

For the curl, maybe for now we can add bash cd hsf-training-cms-analysis-master as an additional instruction?

klieret commented 2 years ago

Actually, how about we only leave the git instruction? I don't see why you would not want the git repository with it and this would make the instructions shorter (and they have seen git before, they have not seen curl, so this would also be easier, right?)

amanmdesai commented 2 years ago

Yes thats easier.

welcome[bot] commented 2 years ago

Congrats on merging your first pull request 🎉! We greatly appreciate it. You might be eligible to be added to the HSF Training Community page (see the instructions on the page for how to create a profile). If you already have created a profile previously, make sure you're also added to the current year. If this repository features a list of contributors at the bottom of the readme, you are also eligible to add yourself there.