search

hsf-training / hsf-training-cpp-webpage

C++ training
https://hsf-training.github.io/hsf-training-cpp-webpage
6 stars 11 forks source link

Remove all namespaces from code #5

Closed klieret closed 3 years ago

graeme-a-stewart commented 3 years ago

Your change looks great - thank you @klieret. Do you know why the CI failed to build the website?

chavid commented 3 years ago

@klieret @graeme-a-stewart I totally approve also.

klieret commented 3 years ago

No, it builds fine, it's just that the carpentry's lesson-check fails, because there are some additional sanity checks, some of which we could solve, some of which are only annoying (consecutive episode numbers being one -- I think they wanted to relax this one, but haven't merged it. Once they do we need to update our styles repo and then bring it in here etc.)

graeme-a-stewart commented 3 years ago

No, it builds fine, it's just that the carpentry's lesson-check fails, because there are some additional sanity checks, some of which we could solve, some of which are only annoying (consecutive episode numbers being one -- I think they wanted to relax this one, but haven't merged it. Once they do we need to update our styles repo and then bring it in here etc.)

OK, thanks for the reminder! To be fixed later then...