search

hshackers / docs

Documentation for HS Hackers
hshackers.org
30 stars 56 forks source link

Easy to spam- remove github/twitter/facebook urls #15

Closed raphaelrk closed 10 years ago

raphaelrk commented 10 years ago

https://github.com/ https://twitter.com/ https://www.facebook.com Can all be removed from the doc without it losing any meaning

sylvia43 commented 10 years ago

Great idea, but let's wait for all the pr's to come in then change it?

raphaelrk commented 10 years ago

Definitely agree

zachlatta commented 10 years ago

Does removing the domain from the URLs really help spam?

raphaelrk commented 10 years ago

Probably not. It could still make things look nicer, getting rid of the horizontal scrollbar on the csv. It also makes it really obvious that a some people put incorrect URLs in anyway to stop bots. Pictures: cleanhs_csv dirtyhs_csv

javascript automation: document.body.innerHTML = document.body.innerHTML.replace( new RegExp("https://www.facebook.com/", 'g'), ''); void 0 document.body.innerHTML = document.body.innerHTML.replace( new RegExp("https://twitter.com/", 'g'), ''); void 0 document.body.innerHTML = document.body.innerHTML.replace( new RegExp("https://github.com/", 'g'), ''); void 0

raphaelrk commented 10 years ago

So yeah, one big advantage to removing URLs is getting rid of incorrect URLs. They would be made a non-issue if we remove URLs from those three columns.

zachlatta commented 10 years ago

When talking with him earlier tonight, @ttaylorr brought up that if we decide to add LinkedIn in the future, it has different URLs for different user profile views. I'm not a big user of LinkedIn myself (and I may have misunderstood him), but this may be an issue if we decide to remove the domain from the URLs.

I do like the idea of no longer having incorrect URLs.

ttaylorr commented 10 years ago

For example, if you have a Facebook "username" your link looks like https://facebook.com/ttaylorr.blau, but if you don't it looks like https://facebook.com/user/. To allow for easy data usage in the future, I'd recommend keeping in the longer URLs.

raphaelrk commented 10 years ago

You mean https://facebook.com/profile.php?id=, right? Either way, I concede. It's easier to use the data when it has the URL beside it

ttaylorr commented 10 years ago

Yeah, I did mean that - thanks @raphaelrk :)

zachlatta commented 10 years ago

I'm going to go ahead and close this issue. If either of you (or anyone else) comes up with a good way to list Facebook profiles that don't have a username without the fully-qualified URL, I do agree with @raphaelrk that the document would be much cleaner with just usernames.