search

hsiaojietng / pe

0 stars 0 forks source link

Duplicate classes can be added #4

Open hsiaojietng opened 2 years ago

hsiaojietng commented 2 years ago

Duplicate classes can be added if the input has different capitalization.

How to reproduce: 1) Input add_class tn/T04 v/LT13 d/Monday tm/13:00 wk/13 and ENTER 2) Check that this class has been successfully added 3) Input add_class tn/t04 v/LT13 d/Monday tm/13:00 wk/13 and ENTER

Expected Result: The second input should not be successfully added as a class since there is already a duplicate that exists.

Actual Result: Both classes added exists and displays in the app.

Logically, this would not be allowed as they represent the same tutorial slot (on Luminus, you are able to see that all tutorials are capitalized)

image.png

soc-pe-bot commented 2 years ago

Team's Response

As per our latest milestone, it is stated in the User Guide that all parameters are case-sensitive. Hence, classes with similar names but different cases will be treated differently.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: However, the UG did not state what happens if 2 classes have the same name but with different case to their name. I believe this would bring up some flaws that would prevent the user to use the app properly.

Example scenario: 1) t04 exists as a class (since this is allowed)

2) The user does not realize and creates another class with the name T04

3) He/She does some commands that links to T04

3) The next time the user uses the app, he/she might assume without checking that she named the tutorial as t04 and does some commands that links to t04, thus causing inconsistent data modifications.