search

hsiaojietng / pe

0 stars 0 forks source link

Allows only number as class title #6

Open hsiaojietng opened 2 years ago

hsiaojietng commented 2 years ago

How to reproduce: 1) Input add_class tn/0 v/LT13 d/Monday tm/13:00 wk/13

Expected result: There should be an error message that states a tutorial cannot only contain numbers.

Actual result This class is successfully added

image.png

nus-se-bot commented 2 years ago

Team's Response

There is no restriction on tutorial names containing only numbers.

We only enforce a constraint that tutorial names must contain alphanumeric characters.

When this is violated, the following error message would be shown:

"Tutorial names should only contain alphanumeric characters and spaces, and should not be blank"

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Since this app is targeted in the context of NUS, it would only be correct if the app only allows the input of tutorial names in this specific format: 'T' (Luminus format) or 'TUT' (NUSMOD format) [Where * can be any 2 digit number]

Since the app does not enforce this rule, a user might accidentally input a tutorial with just a number and that might cause inconvenience.

[From NUSMODS]

image.png

[From Luminus]

image.png