search

hsiaotingluv / pe

0 stars 0 forks source link

Schedule wrong error message when given negative index #9

Open hsiaotingluv opened 2 years ago

hsiaotingluv commented 2 years ago

Input: schedule -1 m/05-Dec-2021 20:00

Expected: The person index provided is invalid

Reason: lack of specificity in error message, same error for other commands

Screenshot 2021-11-12 at 4.41.22 PM.png

nus-pe-bot commented 2 years ago

Team's Response

Error message already states that index must be a positive integer. Since information is already included, this issue is cosmetic at best.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Error messages can be correct but not specific enough i.e., it says the input is 'invalid' without giving the reason. As a user, I may not realise what is wrong with the input.

Additionally, making the error message more specific does not take "a lot more effort", as it can return the same error message as the index out of bound error.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: Error messages can be correct but not specific enough i.e., it says the input is 'invalid' without giving the reason. As a user, I may not realise what is wrong with the input, which results in occasional inconvenience in rare situations like having typo.

Severity remain low.