search

hsingh23 / deckjam

0 stars 0 forks source link

[Suggestion] Lessen DOM load with infinite scrolling #2

Open dggriffin opened 7 years ago

hsingh23 commented 7 years ago

I was thinking of doing this, but I couldn't figure out how to do it with many card sets in an ng repeat. The card set size varies and I haven't figured out how to calc rendered height

On Tue, Dec 13, 2016, 11:17 AM Greyson Griffin notifications@github.com wrote:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hsingh23/deckjam/issues/2, or mute the thread https://github.com/notifications/unsubscribe-auth/ABFXgk5FzR-RZDiKx_eIqYBJdHBS-H0hks5rHsUCgaJpZM4LL6_c .

hsingh23 commented 7 years ago

I added a load more button that fetches more results. I could have this be automatic with some sort of auto loader. The thing I do right now is I replace the terms fetched so far. If I kept adding sets of cards I would increase dom load.

I could use a virtual dom or recycled view that cycles dom nodes - however many of the libraries I've seen don't deal with odd sized - so while this is ideal, I don't think I'll do it right away.

Another reason I don't like virtual views is they break the default browser search since the dom nodes are switched out. I want to build a smart filter that only shows decks based on what you searched. I see that search being powered by a worker thread doing natural language processing - text similarity.