search

hsjoberg / blixt-wallet

Bitcoin Lightning Wallet with focus on usability and user experience
https://blixtwallet.github.io
MIT License
378 stars 68 forks source link

Fix blur situation #182

Closed hsjoberg closed 4 years ago

hsjoberg commented 4 years ago

react-native-blur-overlay has long been causing trouble because of its way of accomplishing blur. It is taking a screenshot of the current screen, applying blur and then sends that back to react-native.

This means that any change of the screen height or if something underneath changes, this will not be reflected. Specifically this causes a lot of issues in the lnurl PayRequest and WebLN Browser screens.

There is a module called @react-native-community/blur, but this lib unfortunately forces either very light or very light background and does not allow us to simply apply a blur filter without any brightness change.

We could look into making a react-native package out of https://github.com/wasabeef/Blurry or any other Android lib

https://github.com/mmin18/RealtimeBlurView

hsjoberg commented 4 years ago

RealtimeBlurView was easy to implement as a native UI module.

For some reason it does not solve Android ripple effect on Settings/On-Chain Transaction List, but it does solve the BlurModal+keyboard issue.

hsjoberg commented 4 years ago

react-native-realtimeblur (internal module right now) implemented in c926bd853d3c2bf84055acd9a072f33993891829