hsjoberg / blixt-wallet

Bitcoin Lightning Wallet with focus on usability and user experience
https://blixtwallet.github.io
MIT License
388 stars 69 forks source link

i18n (german translation in particular) #399

Open jigglycrumb opened 3 years ago

jigglycrumb commented 3 years ago

Hello there!

I really like your wallet and would like to contribute in some way! Since I'm a native German speaker I could (and would like to) provide German translations for the UI.

As far as I have seen, you're using React Native and until now all strings are hard-coded. I'm a React dev but not familiar with Native yet - a bit of googling sent me to this framework for localisation: https://github.com/zoontek/react-native-localize

I don't know I you have thought about i18n yet and if you have a different preference. If not, I would start preparing a PR that adds react-native-localize and extracts the English strings.

In a second step/PR, I'd then add German translations.

Let me know if that sounds fine for you or if you have different plans.

Thanks for your work! 🚀

hsjoberg commented 3 years ago

Thank you for opening this issue and for your pledge to help translating Blixt Wallet to German @hpcodecraft. 🙏

Yes, I would definitely want to support more languages and fixing i18n support to Blixt Wallet's codebase is something I've had mind for some time now, but that has unfortunately seen some delays.

I keep track of the pledges regarding translating different language in a ticket in Blixt project's official Trello board: https://trello.com/c/0f2uqGfl/35-i11n-and-transifex. If it is okay with you, I'll write your github username for the German language.

Also, in case you're using Telegram, you're welcome to join the public chat channel, https://t.me/BlixtWallet. If not, lets discuss the technical implementation of i18n further on email: hampus.sjoberg@protonmail.com. I have not figured out i18 lib for react/react-native yet, but for translation collaboration, my plan is to use Transifex or some similar service.

Cheers! 💯

jigglycrumb commented 3 years ago

This sounds great, thanks for your reply! I'm happy with you adding my name to the trello board (I think I have a trello account somewhere, I'll check it out and then check your link)

I'm not using Telegram anymore, Signal only right now - I'll contact you via email in the next couple of days!

A translation service sounds perfectly fine for me, then I don't have to dive into implementation details 😂