hski-github / spotfire-kanban

Kanban board visualisation for Spotfire
MIT License
2 stars 0 forks source link

Borders showing when using a custom theme #3

Closed arnaudspotfire closed 3 years ago

arnaudspotfire commented 3 years ago

When using a different them than light theme, for instance dark theme or a custom theme with a different background color than white the kanban board shows borders.

Screen Shot 2021-09-09 at 11 37 25

hski-github commented 3 years ago

th, td in main.css should use margin instead of border-color white.

Also .card and .card:hover border-color need to use transparent. And .card:hover outline need to use foreground color from theme.

hski-github commented 3 years ago

Line colors of the theme can be retrieved from the Mods API

https://tibcosoftware.github.io/spotfire-mods/api-docs/interfaces/stylinginfo.html https://tibcosoftware.github.io/spotfire-mods/api-docs/interfaces/linestylinginfo.html

image

hski-github commented 3 years ago

Using styling info return "transparent" as background color for both light and dark theme. TIBCO is preparing Spotfire 11.4 H2, which is fixing this issue.

hski-github commented 3 years ago

Spotfire 11.4 HF deployed (it says Build-Version: 11.5.0.117, Build-Datum: 23.09.2021) to Spotfire Cloud and Kanban layout working fine in both light and dark theme.