Services config simplification and conversion to php + prevent error when session doesn't used

hslavich / OneloginSamlBundle

OneLogin SAML Bundle for Symfony

MIT License

149 stars 94 forks source link

Services config simplification and conversion to php + prevent error when session doesn't used #127

Closed a-menshchikov closed 4 years ago

a-menshchikov commented 4 years ago

Change services config format from yaml to php
Do not call Request::getSession if session does not used
Use class name as service id instead of aliases
Added some type hints

a-menshchikov commented 4 years ago

@hslavich If this PR is well and will be merged, make next minor version tag, please.

a-menshchikov commented 4 years ago

I'm planning to create PR with replacement of "legacy" security authentication listener/provider by new authenticator. It will also contain changes from this PR.