search

hslayers / hslayers-ng

User interface and map building extensions for OpenLayers
https://ng.hslayers.org/
MIT License
36 stars 20 forks source link

Styler opacity not working #1956

Closed jmacura closed 3 years ago

jmacura commented 3 years ago

The opacity sliders does not do anything for me.. image image The same goes for stroke

DailisLangovskis commented 3 years ago

@jmacura Hey, yes this is a known issue, but good thing You added it on the issue list, so it is not forgotten. Raitis warned about it and for now the opacity of the features can be modified using the alpha channel from color picker.

P.s. It will most likely won't be fixed for the 5.0 release, because it is not the only issue regarding SLDs. A would add it for the Future milestone instead.

jmacura commented 3 years ago

Oh, I remembered Raitis was warning about something not working right now, but didn't remember what was that in particular šŸ˜„ Thanks for pointing it out. OK, in that case I propose to make the slider disabled for now (perhaps with some tooltip like "not yet supported"). Just a UX change.

DailisLangovskis commented 3 years ago

Well actually there was already something like You suggested, a tooltip informing that the sliders currently are not working as they should. Has it been removed?

jmacura @.***> (Ŕajā datumā: pirmd., 2021. g. 28. jūn. 16:36) rakstīja:

Oh, I remembered Raitis was warning about something not working right now, but didn't remember what was that in particular šŸ˜„ Thanks for pointing it out. OK, in that case I propose to make the slider disabled for now (perhaps with some tooltip like "not yet supported"). Just a UX change.

ā€” You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/hslayers/hslayers-ng/issues/1956#issuecomment-869691823, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALDII24XRU3JYSUXNHAH4P3TVB3G5ANCNFSM47NURAFA .

jmacura commented 3 years ago

Well actually there was already something like You suggested, a tooltip informing that the sliders currently are not working as they should. Has it been removed?

~I can't find it now...~

Ah, I can see now that it is present at "Line" symbolizer, but is missing for "Mark" symbolizer image

FilipLeitner commented 3 years ago

Is it even necessary to have separate slider for opacity when its possible to set opacity using color-picker? image

DailisLangovskis commented 3 years ago

Well, the only reason I could think of, why it is necessary, is for those users, who doesn't now how alpha channel works in color picker. Opacity slider makes it easier to understand.

FilipLeitner @.***> (Ŕajā datumā: treŔd., 2021. g. 30. jūn. 11:52) rakstīja:

Is it even necessary to have separate slider for opacity when its possible to set opacity using color-picker? [image: image] https://user-images.githubusercontent.com/44566616/123931694-0ad2bb00-d991-11eb-8670-2f4dec2bfb7d.png

ā€” You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/hslayers/hslayers-ng/issues/1956#issuecomment-871217368, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALDII2Y47XGWLIYVZVE5OVLTVLLLFANCNFSM47NURAFA .

raitisbe commented 3 years ago

No its not necessary, but its in the type definitions of geostyler so might be supported by the standard or some of sld parser implementations. I think i had it working in some scenario for marker thus didnt add the tooltip

jmacura commented 3 years ago

FTR, I recall that the opacity slider works fine for IconSymbolizers. image