hslayers / hslayers-ng

User interface and map building extensions for OpenLayers
https://ng.hslayers.org/
MIT License
37 stars 20 forks source link

Fill symbolizer affects line symbolizer (and vice versa) #2148

Closed jmacura closed 3 years ago

jmacura commented 3 years ago

Bug

Describe the bug When a Line symbolizer is set, it also affects the symbology of polygon boundaries. Vice versa, when a Fill symbolizer is set with some outline colour, it affects the symbology of lines.

To Reproduce Steps to reproduce the behavior:

  1. Open some layer with polygons and lines or draw some.
  2. Go to Styler
  3. Create Line symbolizer
  4. Set some colour and width

Expected behavior Line symbolizer shall be only applied to lines. Fill symbolizer shall be only applied to polygons.

Screenshots image image image

Additional context Or perhaps not... Could this be a desired behaviour?

raitisbe commented 3 years ago

Yeah, I dont think we can classify it as a bug. User must know what he's doing and probably the fix would need to be made in the geostyler anyway. Will leave it open for a bit.

fzadrazil commented 3 years ago

What is misleading here is the fact that there is an outline settings in the Fill symbolizer and line settings in Line symbolizer which does the same, but are not synchronized. So the user would suppose Outline only affects fill symbols and Line symbolizer only polylines. Eg. when you change the outline color, it won't change the value in Line symbolizer, but the lines get changed and vice versa.

raitisbe commented 3 years ago

Yes, but looking from the other side, there would not be a possibility to draw these nice contours around the line in another color, if we synchronized fill symbolizers outline color to line symbolizers color.

jmacura commented 2 years ago

Just leaving a note that this will be confusing for any end-user and I still consider it a UX-bug. obrazek