search

hslayers / hslayers-ng

User interface and map building extensions for OpenLayers
https://ng.hslayers.org/
MIT License
37 stars 20 forks source link

Multiapp share #2821

Closed FilipLeitner closed 2 years ago

FilipLeitner commented 2 years ago

Behavior of share panel or rather pure/full app permalinks for multiple apps is not really in sync with the multi-app behavior of the rest of the app right now. It will always share whole container application not individual instances of hslayers. I imagine this could be kinda resolved by redirecting to some single app instance prepared for this. We would probably need to parse app config params into share composition .

How should we tackle this aspect, what do you think?

raitisbe commented 2 years ago

I think it is fine that it shares the container application. I suppose in case when we have multiple apps on a page scattered between blocks of text etc. the apps would not make much sense individually.

fzadrazil commented 2 years ago

I agree with Raitis. I was even thinking whether the share tool has any meaning for multiple apps and shouldn't be disabled in that case.

raitisbe commented 2 years ago

Scrolling to the app where the share panel is active could be made with an extra param in the url.