search

hslayers / hslayers-ng

User interface and map building extensions for OpenLayers
https://ng.hslayers.org/
MIT License
37 stars 20 forks source link

Select type of service when uploading new layer #3440

Closed fzadrazil closed 1 year ago

fzadrazil commented 2 years ago

Feature Request

Is your feature request related to a problem? Please describe. When I want to upload a new layer to Layman, it gets automatically added to the current map, but without a change to select, whether it will be added as WMS or WFS. It is always added as WFS.

Describe the solution you'd like Add a WMS/WFS selector to the layer upload form in the same manner as if I add existing layer to the map.

DailisLangovskis commented 2 years ago

I am probably the only one, but I don't know from where exactly we upload a new layer to Layman. Is it when creating a new drawing layer?

fzadrazil commented 2 years ago

Nope, it is in Datasources panel, File tab. When you select SHP or GeoJSON, there is "Save to database" flag, which means "publish it to Layman". I think @FilipLeitner has implemented that.

DailisLangovskis commented 2 years ago

Oh yes, that's right!

FilipLeitner commented 2 years ago

It is always added as WFS.

I think SHP is added as WMS while other sources such as GeoJSON result in WFS layer.

fzadrazil commented 2 years ago

Well, the main issue is that WFS is added without styling. So when I add a GeoJSON with SLD, it gets added as WFS, but with default styling. But that is different issue.

I think SHP is added as WMS while other sources such as GeoJSON result in WFS layer.

Yes, I tried and you are right.

jmacura commented 2 years ago

Proposed UI mock-up of this feature image

For shapefile, the WMS option will be pre-selected. For other vector files, the WFS option will be pre-selected. Keeping the status quo. Any comments @fzadrazil or anyone?

DailisLangovskis commented 2 years ago

Looks good to me!

jmacura @.***> (šajā datumā: piektd., 2022. g. 4. nov. 14:30) rakstīja:

Proposed UI mock-up of this feature [image: image] https://user-images.githubusercontent.com/5598693/199972762-871c1330-6980-4400-85db-523b0ae9348d.png

For shapefile, the WMS option will be pre-selected. For other vector files, the WFS option will be pre-selected. Keeping the status quo. Any comments @fzadrazil https://github.com/fzadrazil or anyone?

— Reply to this email directly, view it on GitHub https://github.com/hslayers/hslayers-ng/issues/3440#issuecomment-1303432991, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALDII2Z4DPM3G2X2ESPKG2TWGT6XBANCNFSM6AAAAAARCRP2LM . You are receiving this because you commented.Message ID: @.***>

fzadrazil commented 2 years ago

For shapefile, the WMS option will be pre-selected. For other vector files, the WFS option will be pre-selected. Keeping the status quo. Any comments @fzadrazil or anyone?

Agreed. And the proposed GUI looks fine.