search

hslayers / hslayers-ng

User interface and map building extensions for OpenLayers
https://ng.hslayers.org/
MIT License
34 stars 20 forks source link

Check if geostyler workarounds still needed #3677

Closed raitisbe closed 6 months ago

raitisbe commented 1 year ago

Feature Request

Is your feature request related to a problem? Please describe. Some long standing bugs were fixed in geostyler:

Version 4.1.0 What's Changed Updates openlayers to v7 and geostyler-style to v7 by @​KaiVolland in geostyler/geostyler-openlayers-parser#595 fontWeight and fontStyle from textSymbolizer by @​pragmaeuge in geostyler/geostyler-openlayers-parser#615 Update geostyler-style by @​hwbllmnn in geostyler/geostyler-openlayers-parser#647 fillOpacity support for the markSymbolizer geostyler object by @​pragmaeuge in geostyler/geostyler-openlayers-parser#621 Drop support for IconSymbolizer.size by @​KaiVolland in geostyler/geostyler-openlayers-parser#648 Remove graphicFill from unsupportedProperties by @​KaiVolland in geostyler/geostyler-openlayers-parser#656 Updates dependencies (ol to v7.2) and readd size parsing by @​KaiVolland in geostyler/geostyler-openlayers-parser#657

Describe the solution you'd like

Check if our workarounds are still needed. Some which come to mind are fillOpacity for MarkSymbolizer and tooltips about attributes not suported

FilipLeitner commented 1 year ago

Drop support for IconSymbolizer.size

FilipLeitner commented 6 months ago

Drop support for IconSymbolizer.size

  • The upcoming ol release will include width and height for the ol/style/Icon . <-- already released... so we will be able to implement it correctly with the next ol version: <--not yet

Should be ok - https://github.com/geostyler/geostyler-openlayers-parser/issues/624#issuecomment-1413875386. Sets widht and height of OL icon