hslayers / hslayers-ng

User interface and map building extensions for OpenLayers
https://ng.hslayers.org/
MIT License
37 stars 20 forks source link

Revise component subscriptions #4666

Closed FilipLeitner closed 8 months ago

FilipLeitner commented 10 months ago

Shared hslayers fucntionality should not rely on subscriptions created in components.

Example: An app should be able to consume functionality thats provided by layermanager service such as event triggers for newly added layers

image

However this is currently not possible without layermanager component as it is its constructor which creates a handler.

image

In other words subscriptions or other actions that concern the functionality of services should be initiated in services (either through helpers or directly ) not panel components

FilipLeitner commented 8 months ago

Went through search results for regex ce\.[\w\d]{1,50} = (ce. as ending of word service followed word character (letters, digits, or underscores) or digit, between 1 and 20 times) in *.component.ts files and found nothing suspicious so it seem this was an exception.