Traslations: simplified pipe & better sensors' chart localization - Githubissues

hslayers / hslayers-ng

User interface and map building extensions for OpenLayers

https://ng.hslayers.org/

MIT License

36 stars 20 forks source link

Traslations: simplified pipe & better sensors' chart localization #5057

Closed FilipLeitner closed 2 months ago

FilipLeitner commented 3 months ago

Description

Add new param for HsConfig.senslog configuration -> `timeFormatConfigPath`.

Allows the customization of vega embed view timeFormatLocale . This customization includes defining how dates and times are displayed (e.g., day names, months, time formats) to match the linguistic and regional preferences. Example of such configuration for cs localization can be found in projects/hslayers-sensors/src/components/sensors/time-format-config/cs.json

Simplified customTranslationPipe and changed preferred args format.

more readable and straightforward trasnform function
removed basically unused onTranslationChange subscribtion
expect string 'module' argument (with backwards compatiblity preferably until next major v.).

Related issues or pull requests

closes #5056

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Dependency updates
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe)
[ ] I am unsure (we'll look into it together)

Do you introduce a breaking change?

[ ] Yes
[x] No
[ ] I am unsure (no worries, we'll find out)

Checklist

[x] I understand and agree that the changes in this PR will be licensed under the [MIT License]
[ ] I have followed the guidelines for contributing
[ ] The proposed change fits to the content of the code of conduct
[ ] I have added or updated tests and documentation, and the test suite passes (run npm test locally)
[ ] I'm lost; why do I have to check so many boxes? Please help!