hslayers / map-compositions

MIT License
0 stars 0 forks source link

Proposed changes for v2.0.0 #1

Closed fzadrazil closed 2 years ago

fzadrazil commented 2 years ago
fzadrazil commented 2 years ago

There is one more property in the Layman version of the schema compared to HSLayers version. Do we need to include it or is it safe to remove?

              "FROMCRS": {
                "$id": "#/properties/layers/items/properties/params/properties/FROMCRS",
                "type": "string",
                "title": "CRS used if serverside reprojection is needed",
                "default": "",
                "examples": [
                  "EPSG:3857"
                ],
                "pattern": "^(.*)$"
              },
raitisbe commented 2 years ago

Its safe to remove. Was used in old p to oxy4ows created in python

On Wed, 8 Dec 2021, 18:22 fzadrazil, @.***> wrote:

There is one more property in the Layman version of the schema compared to HSLayers version. Do we need to include it or is it safe to remove?

          "FROMCRS": {
            "$id": "#/properties/layers/items/properties/params/properties/FROMCRS",
            "type": "string",
            "title": "CRS used if serverside reprojection is needed",
            "default": "",
            "examples": [
              "EPSG:3857"
            ],
            "pattern": "^(.*)$"
          },

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/hslayers/map-compositions/pull/1#issuecomment-988964005, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADAR6TMF4R3FSW5RQ3P5WDUP6A3XANCNFSM5JRPLUAA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

jirik commented 2 years ago

Form Layman's point of view it's also safe to remove FROMCRS.