hsp-iit / tour-guide-robot

5 stars 9 forks source link

Libfvad does not build and possible solutions for VAD problems #12

Open DatSpace opened 2 years ago

DatSpace commented 2 years ago

Libfvad, the webrtc library we were using for VAD seems to be stale for a while and it has problems building on ubuntu 22. Further than that, it seems to be based off an old commit of the webrtc library. A quick search for webrtcvad (The old python version we were using) shows that the fork is around 2016.

https://github.com/wiseman/py-webrtcvad

And : https://github.com/wiseman/py-webrtcvad/issues/69

To be fair we are using the CPP version which even though we had performance improvements, we still had a lot of false positives. https://github.com/dpirch/libfvad

Proposed solutions:

DatSpace commented 2 years ago

The problem was that the configuration for autoreconf had a "patch" for the previous version of autoreconf that was fixed in the latest version. Ubuntu 22 comes with the latest version of the software so there was a mismatch.

In any case, fixed with b05afcdfd8c392ec58eb13cbde19a93c083619db

DatSpace commented 2 years ago

I will actually leave it open as it can be used as a reminder for possibly upgrading the VAD in the future. The issue is fixed though.