search

hspotlight / metro-fare

metro-fare.vercel.app
MIT License
14 stars 13 forks source link

Any plan to introduce lintting tools to the project #15

Open thanakritju opened 4 years ago

thanakritju commented 4 years ago

we can have something like auto format code, remove white spaces ..

or is there any vscode plugin recommend

hspotlight commented 4 years ago

Normally, TS has tslint.json for linting configuration, and can be execute every time we commit source code. Currently, I haven't configure it yet. :(

thanakritju commented 4 years ago

let me working on this, as tslint has been deprecated.

will use eslint

heyfirst commented 4 years ago

I would suggest that do not add the lint because create-react-app recommend user to use prettier instead of eslint. (https://create-react-app.dev/docs/setting-up-your-editor/#formatting-code-automatically).

I have implement the husky and prettier in this PR (#18)

please check it.