hsrob / TrueVault.Net

.NET wrapper for the TrueVault API
https://www.truevault.com
MIT License
3 stars 3 forks source link

Did not build #1

Closed brianpullin closed 10 years ago

brianpullin commented 10 years ago

Error 2 'string' does not contain a definition for 'PostToUrl' and no extension method 'PostToUrl' accepting a first argument of type 'string' could be found (are you missing a using directive or an assembly reference?) C:\projects\TrueVault.Net-master\TrueVault.Net-master\TrueVault.Net\TrueVaultClient.cs 57 26 TrueVault.Net

Line of error: return VaultDocumentsUrl(vaultId) .PostToUrl(documentRequestDto, requestFilter: AuthorizationHeader) .MapResponseDto<DocumentSuccessResponseDto, DocumentSuccessResponse>();

All the PostToUrl, DeleteFromUrl,GetStringFromUrl, and .fmt lines had compile failures.

Using VS 2013.

Do need another package? I did not see where HTTP request were actually being made.

hsrobmln commented 10 years ago

Hi Brian,

PostToUrl (as well as GetStringFromUrl, PutToUrl, etc.) are in the ServiceStack.Text NuGet package/namespace. Do you have NuGet package restore enabled? If so, please make sure ServiceStack.Text 3.9.71 is installed in your project. Let me know if this helps.

brianpullin commented 10 years ago

only different is that I have ServiceStack.Text version 4.0.30.0.

Brian Pullin Pullin Development mailto:brian@pullindev.com (510)526-0369 Mobile:(510)206-0576

Microsoft Certified Solution Developer

On Aug 18, 2014, at 10:00 PM, Robert Parker notifications@github.com wrote:

Hi Brian,

PostToUrl (as well as GetStringFromUrl, PutToUrl, etc.) are in the ServiceStack.Text NuGet package/namespace. Do you have NuGet package restore enabled? If so, please make sure ServiceStack.Text 3.9.71 is installed in your project. Let me know if this helps.

— Reply to this email directly or view it on GitHub.

hsrob commented 10 years ago

Hi Brian, can you try it with 3.9.71 specifically? 4.x was a major update with a lot of API changes, so I don't know that it will work properly. I do have a 4.x commercial license and usually use it, so I will check and try to add compatibility with both versions when I push the next update (soon).

brianpullin commented 10 years ago

A couple things:

I want some additional functionality and did not want to base the code on some that was not compatible with the latest version of critical 3rd party lib.   So, using TrueVault.Net as a template, I created a TrueVault client/driver.

2nd,   
    I do not think TrueVault is secure.  ( I have been through PCI compliance audits).   It has a two major flaws 

The VaultId is in the URL which is critical piece of info.
    I realize this is following  REST technique of placing information in the URL.    I also think if it was on private network behind a firewall.  It would be OK.
    But over the internet the URL string is exposed and seeing the VaultId displays a critical internal ID of the system.  (would fail PCI, I at least I seen failures for that reason.)

Worst, a hacker only need 1 secret to get complete access.  
    Unlike AWS S3 that does a AccessKey and SecretKey, True Vault only has 1 app key.   

I did not see any IP filtering that can be setup to limit where calls are made from.   If IP filtering was in place or a vpn connection option, I could secure the communication from my data center/hoster to TrueVault.   Instead, TrueVault seems like a good target for a Man-in-the-Middle attack vector. 

Seems like TrueVault would be a cool private network solution for now...

Brian Pullin Pullin Development mailto:brian@pullindev.com (510)526-0369 Mobile:(510)206-0576

Microsoft Certified Solution Developer

On Aug 22, 2014, at 11:04 AM, Robert Parker notifications@github.com wrote:

Hi Brian, can you try it with 3.9.71 specifically? 4.x was a major update with a lot of API changes, so I don't know that it will work properly. I do have a 4.x commercial license and usually use it, so I will check and try to add compatibility with both versions when I push the next update (soon).

— Reply to this email directly or view it on GitHub.

joseph-adam commented 10 years ago

If you are on a clean install of VS you'll need to do the following:

Open the package manager console (tools > library package manager > package manager console) and run the following commands.

install-package ServiceStack.Text -Version 3.9.71

install-package automapper

make a reference in the truevault.net project to [project path]\hsrob-TrueVault.Net-db15b9a\packages\ServiceStack.Text.3.9.71\lib\net35\ServiceStack.Text.dll

You should now get a clean build.

Joe Arnone email: joe@openhospital.com

hsrob commented 10 years ago

Hi, I'm going to close this issue as there hasn't been further comment on the issue mentioned, and the other comments may be pertinent, but are not related to this library.