swagger: do not pack slf4j

[maggu2810]

Hello, this package is named swagger-all. Do you really want to bundle all dependencies or just the most? I would prefer to not bundle the slf4j logging, as it is just so a common bundle in the most OSGi based applications. What do you think about?

[hstaudacher]

hmm, basically a good idea. One thought: the reason for this all bundle is to have all dependencies together when using Eclipse + PDE because it's a pain to care about all dependencies manually. When we do not package slf4j we should transform it to use import packages and also deliver slf4j as a bundle within the swagger feature.

[maggu2810]

reason for this all bundle is to have all dependencies together when using Eclipse + PDE because it's a pain to care about all dependencies manually

All fine, it could be difficult to track all dependencies. What do you prefer:

• creation of swagger-min (or something between min and all) and remove slf4j first and perhaps other stuff later, too
• keep the name swagger-all but removing the well common slf4j

we should transform it to use import packages

Already done with this PR.

deliver slf4j as a bundle within the swagger feature

Okay, I have not modified the feature (caused I am not very familiar with Eclipse PDE).

[maggu2810]

Hm, it is a valid argument that we (you g) have to decide what should be bundled. I respect that all means all. The next person request to remove the apache commons etc.

[hstaudacher]

jepp ;). But I also see that logging is kind of a special topic right?

[maggu2810]

Yes, I think so, too.

[maggu2810]

Do you for something I should do?

[maggu2810]

As there is no response, I assume there is no interest upstream.