hstaudacher / osgi-jax-rs-connector

An OSGi - JAX-RS 2.0 Connector, software repository available on the link below
http://hstaudacher.github.io/osgi-jax-rs-connector
Other
190 stars 98 forks source link

erronous requirements in p2 cause eclipse product export to fail #19

Closed dcaillia closed 10 years ago

dcaillia commented 10 years ago

Using buckminster: complains on com.eclipsesource.jaxrs.consumer.source

[ant] !MESSAGE Missing requirement: OSGi - JAX-RS Connector 3.1.0.201309301542 (com.eclipsesource.jaxrs.connector.feature.feature.group 3.1.0.201309301542) requires 'com.eclipsesource.jaxrs.consumer.source [2.1.0.201309301542]' but it could not be found

Using PDE product export: complains on A.PDE.Target.Platform Cannot be installed into the IDE 0.0.0'

Cannot complete the install because one or more required items could not be found. Software being installed: com.barco.nimbus.main 0.0.0 (com.barco.nimbus.equinox.app.SCApplication 0.0.0) Missing requirement: OSGi - JAX-RS Connector 3.1.0.201309301542 (com.eclipsesource.jaxrs.connector.feature.feature.group 3.1.0.201309301542) requires 'A.PDE.Target.Platform Cannot be installed into the IDE 0.0.0' but it could not be found Cannot satisfy dependency:

hstaudacher commented 10 years ago

It's the same you saw in the target editor. I don't know buckminster well but is there a way to disable p2.greedy?

dcaillia commented 10 years ago

So far the only answer i got (from buckminster-dev mailing list) to this question was: "no, I don't think there is a way to disable it in p2 ... its a function of how the IU/bundle was defined and published". Any chance you'ld consider to change the dependencies such that the problem goes away?

Please be aware that this problem is not only for buckminster, but also for the regular eclipse pde product export wizard.

hstaudacher commented 10 years ago

Alright, so we are using the p2 repository for several projects without any problems. I can't spend the effort to investigate here. But I would be happy if you can resolve the problem in a fork and open a pull request. I will then verify it.

hstaudacher commented 10 years ago

We also use the p2 repo with tycho without any problems.

dcaillia commented 10 years ago

I've removed the dependencies to the *.sources bundles from build/com.eclipsesource.jaxrs.connector.feature/feature.xml and build/com.eclipsesource.jaxrs.jersey.runtime.feature/feature.xml, this fixes the problem.

Therefore i think the complete solution is to have a separate feature for source bundles. Is there any particular reason why you chose to put them together with the binary bundles?

hstaudacher commented 10 years ago

No special reason. As more as I think about it I thin it's a stupid idea to put them in one feature.

Would you like to create a source feature or should I?

dcaillia commented 10 years ago

It's my first time on github and tycho, so it's a good exercise for me, but i don't know if i'll manage it soon. I'll try to make a pull request :) later today.

hstaudacher commented 10 years ago

Fixed with commit 602739514e6936d5cb0749778165b0d4bb040c51