search

hstaudacher / osgi-jax-rs-connector

An OSGi - JAX-RS 2.0 Connector, software repository available on the link below
http://hstaudacher.github.io/osgi-jax-rs-connector
Other
190 stars 98 forks source link

Fix an issue when running inside a Karaf container. #26

Closed ddragosd closed 10 years ago

ddragosd commented 10 years ago

When deploying this bundle in a karaf container the bundle activator would fail to register Jersey. that was due to Jersey trying to make use of hk2 framework; in OSGI hk2 doesn't make sense and so I have set 2 properties to disable the self-discoverability.

hstaudacher commented 10 years ago

Thanks @ddragosd for your contribution. I wasn't aware of these properties. But I think it makes sense to set them ;)

I have a few questions:

ddragosd commented 10 years ago

"why do you have changed the root path?"

The 2 properties that I've set to the Root App are critical in order to start Jersey correctly. That would be really nice to have it in your repo.

If the first 2 points are out of the merge context, do we still need the test cases ?

Thanks, Dragos

On Wed, Oct 30, 2013 at 10:22 AM, Holger Staudacher < notifications@github.com> wrote:

Thanks @ddragosd https://github.com/ddragosd for your contribution. I wasn't aware of these properties. But I think it makes sense to set them ;)

I have a few questions:

  • why do you have changed the root path? I guess it was not committed by purpose. if you want to change it in your application you can use the configuration admin, see this FAQ entryhttps://github.com/hstaudacher/osgi-jax-rs-connector/wiki/FAQ#how-can-i-change-the-services-root-path
  • How can the type be null in the ResourceTracker?
  • Before I can merge the request we need some test cases for it. Can you step in and provide them?

— Reply to this email directly or view it on GitHubhttps://github.com/hstaudacher/osgi-jax-rs-connector/pull/26#issuecomment-27415098 .

hstaudacher commented 10 years ago

You are in Ludwigsburg right now? I will be there tomorrow. I would love to see what you have presented. Would you like to meet after lunch?

Regarding the test cases. Yes we do need them. But for this small change I will takeover :)

We have still 3 pull requests open. Hopefully I will find time the next days to merge all of them.

ddragosd commented 10 years ago

Yes, I'm in Ludwigsburg and tomorrow is the last day of the conf. I'd like to meet too. Are you coming to the conference ? Feel free to write me @ ddascal [at] adobe.com to set the details.

Cheers,

dragos dascalita haut

Sent from my iPad

On Oct 30, 2013, at 8:37 PM, Holger Staudacher notifications@github.com wrote:

You are in Ludwigsburg right now? I will be there tomorrow. I would love to see what you have presented. Would you like to meet after lunch?

Regarding the test cases. Yes we do need them. But for this small change I will takeover :)

We have still 3 pull requests open. Hopefully I will find time the next days to merge all of them.

— Reply to this email directly or view it on GitHub.