search

hstaudacher / osgi-jax-rs-connector

An OSGi - JAX-RS 2.0 Connector, software repository available on the link below
http://hstaudacher.github.io/osgi-jax-rs-connector
Other
190 stars 98 forks source link

backport for OSGi R4 #49

Closed greencable closed 10 years ago

greencable commented 10 years ago

Hi Holger,

Here is the pull request for the R4 compatibility.

Thanks, Guillaume

hstaudacher commented 10 years ago

Hi Guillaume, sorry for the delay. Today I found time to review the change. I have some good and bad news ;)

First the tests were red. I had to fix them but now it works. The other thing is that I believe the backport was not complete. E.g. the configuration admin was imported with version 1.3.0 but r4 exports 1.2.0.

I also change the implementation because the backport had a lot of compiler warnings.

I pushed the update to the branch https://github.com/hstaudacher/osgi-jax-rs-connector/tree/osgi-r4-compatibility

Can you check it out and verify that everything is still working for you?

greencable commented 10 years ago

Hi Holger,

Thanks for your answer and your work.

I’ll take one month off and after I’ll try to integrate in our software to tell you if it’s ok.

Best regards,

Guillaume

From: Holger Staudacher [mailto:notifications@github.com] Sent: dimanche 18 mai 2014 23:01 To: hstaudacher/osgi-jax-rs-connector Cc: greencable Subject: Re: [osgi-jax-rs-connector] backport for OSGi R4 (#49)

Hi Guillaume, sorry for the delay. Today I found time to review the change. I have some good and bad news ;)

First the tests were red. I had to fix them but now it works. The other thing is that I believe the backport was not complete. E.g. the configuration admin was imported with version 1.3.0 but r4 exports 1.2.0.

I also change the implementation because the backport had a lot of compiler warnings.

I pushed the update to the branch https://github.com/hstaudacher/osgi-jax-rs-connector/tree/osgi-r4-compatibility

Can you check it out and verify that everything is still working for you?

— Reply to this email directly or view it on GitHub https://github.com/hstaudacher/osgi-jax-rs-connector/pull/49#issuecomment-43451459 . https://github.com/notifications/beacon/7314645__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxNjA2NjA1MSwiZGF0YSI6eyJpZCI6MzAyNDkzNDN9fQ==--18f2d3b2c1cde4e6f8beda952fd0abcca67e3577.gif

hstaudacher commented 10 years ago

Alright. Will merge it into master because I have tested it a lot with Equinox 3.6 the last days

hstaudacher commented 10 years ago

Applied with version 4.0