Closed hstaudacher closed 9 years ago
ApplicationConfiguration is looking good
Seems to work well with openHAB. My only concern is that the jersey-all bundle has again grown in size from 5448789 to 6157007 byes. For embedded use this is an incredibly fat bundle and I would very much wish to shrink it as much as possible.
Thanks for testing. @kaikreuzer one idea:
What about creating an additional jersey-min bundle and deliver it together with the all bundle. So it will be up to the user which one he want's to use. But this would require your help. The all bundle has a separate maven build. It takes all dependencies into the bundle during the build. See https://github.com/hstaudacher/osgi-jax-rs-connector/blob/master/build/com.eclipsesource.jaxrs.jersey.all/pom.xml#L117
So, can you just duplicate this build and reduce the dependencies to the level you need and open a pull request? I would integrate it and include it in the release.
A jersey-min bundle sounds like a good idea! @kolkoo already stripped out all client stuff from Jersey and he will create a PR for you. Size is then around 4MB.
Thanks. Will integrate over the weekend
I did a very basic test with Bndtools, and it is working.
Thanks @BryanHunt
@kaikreuzer I have integrated the jersey-min bundle in the build. Here is the RC2 repository with the min bundle included. Can you give it a try? https://dl.dropboxusercontent.com/u/5808972/com.eclipsesource.jaxrs.repository-4.3.0-RC2.zip
Hi, if you change the dependencies also to the SNAPSHOTS, such as:
...
<groupId>com.eclipsesource.jaxrs</groupId>
<artifactId>jersey-all</artifactId>
<version>2.17</version>
</dependency>
...
to 2.17-SNAPSHOT
I can continue testing. And it's "swookiee" :grin:
@larsp I don't get it. Why is this change required?
Because there is no 2.17 but only a 2.17-SNAPSHOT in the repository: https://oss.sonatype.org/content/repositories/staging/com/eclipsesource/jaxrs/jersey-all/ and you are referencing a release version which is not there yet, I assume.
Oh, I see ;) It's currently uploading and should be available in a few minutes.
If you like you can also provide a regular staging release build instead of a snapshot. Just without releasing. In case it is easier?
@larsp just uploaded a new version
@hstaudacher same, no bytecode in publisher-4.3-20150322.145840-9.jar instead the html I would expect in a -javadoc.jar
just with a Manifest.
@larsp damn. I messed up. Found the problem and it's fixed now. A valid version is online. Sorry for this
Works, great! :shipit:
Alright. Testing done. Will release 4.3 shortly
Thanks you all for your effort. It's very appreciated...
4.3 is published -> https://github.com/hstaudacher/osgi-jax-rs-connector/releases/tag/4.3.0
Thank you all for the big help!
The 4.3.0 RC1 is ready to be tested including the new ApplicationConfiguration API (see #88).
Maven: https://oss.sonatype.org/content/repositories/snapshots/ ziped p2 repo: https://dl.dropboxusercontent.com/u/5808972/com.eclipsesource.jaxrs.repository-4.3.0-RC1.zip
@kaikreuzer can you test it with openHAB? @stefanseifert can you test the maven stuff? :) @BryanHunt bnd repo also included in the zip archive ;) @larsp can you test the new version with Swookie? @isole Can you test the ApplicationConfiguration stuff?
Will publish the release next monday if no-one vetoes or requests more time. Thanks guys!