search

hstonel / gitblit

Automatically exported from code.google.com/p/gitblit
Apache License 2.0
0 stars 0 forks source link

StartTLS is not supported in LdapUserService #122

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Have an LDAP server that requires clients to send StartTLS after opening 
plain text connection (and not use a SSL connection)
2. Authenticate against such an LDAP server
3. Connection fails, because there's no way to tell GitBlit to send the StartTLS

LdapUserService should call StartTLSExtendedRequest, in case a ldap+tls:// URL 
is configured, see 
https://www.unboundid.com/products/ldapsdk/docs/javadoc/com/unboundid/ldap/sdk/e
xtensions/StartTLSExtendedRequest.html

Original issue reported on code.google.com by stef...@steffen-gebert.de on 9 Aug 2012 at 8:51

GoogleCodeExporter commented 9 years ago 
Thanks for the documentation link.  I assume you require this behavior for your 
LDAP server.  I can add in support for this, if you can build from source and 
test it for me.

Original comment by James.Mo...@gmail.com on 9 Aug 2012 at 12:32

GoogleCodeExporter commented 9 years ago 
I've already a patch.. will do a pull request, soon.

Original comment by stef...@steffen-gebert.de on 9 Aug 2012 at 12:33

GoogleCodeExporter commented 9 years ago 
Awesome.

Original comment by James.Mo...@gmail.com on 9 Aug 2012 at 12:42

GoogleCodeExporter commented 9 years ago 
https://github.com/gitblit/gitblit/pull/23

Original comment by stef...@steffen-gebert.de on 9 Aug 2012 at 1:46

GoogleCodeExporter commented 9 years ago

Original comment by James.Mo...@gmail.com on 9 Aug 2012 at 1:58

GoogleCodeExporter commented 9 years ago

Original comment by James.Mo...@gmail.com on 20 Aug 2012 at 2:06

GoogleCodeExporter commented 9 years ago 
Fix/change released in 1.1.0.

Original comment by James.Mo...@gmail.com on 25 Aug 2012 at 12:20