hstove / electron-cookies

Adds support for cookies in Electron. Cookies are persisted through localStorage.
MIT License
124 stars 30 forks source link

Cookie expiration #9

Open sean3z opened 8 years ago

sean3z commented 8 years ago

Have you given any thought to cookie expiration?

key=value; Expires=Thu, 01-Jan-1970 00:00:01 GMT
loming commented 8 years ago

It didn't handle any cookie expiration at the moment, on the other hand, it's killing the cookie if u are trying to set with the expiration date.

if (parts.length === 2) { key = parts[0], value = parts[1]; } else { value = parts[0]; key = ''; }

Mercieral commented 8 years ago

I would like to see some form of cookie expiration done as well.