search

hstove / send-many-stx-cli

A simple CLI for making a bulk STX transfer in one command.
MIT License
4 stars 4 forks source link

Feature Request: enforce non-empty memo when using `send-many-memo` #3

Open wileyj opened 3 years ago

wileyj commented 3 years ago

https://github.com/blockstack/send-many-stx-cli/#stx-bulk-transfer-send-many-memo-recipients

if two tx's are added with no memo, they are combined into a single tx - adding a requirement that memo not be empty, or if 2 tx's have non-empty memos, they shouldn't be combined.

for example: https://explorer.stacks.co/txid/0x11fdb3b129ac439adf8dd5b3f27f749ad48c4ea9339060965d7916064329e237?chain=mainnet

in the contract, there is a tx for STX tokens(5049.3925) was exactly the same as the sum of missing tokens for 2 addresses ( 331.3772 + 4718.0153 = 5049.3925 )

I think it would be more enforceable from the code to check for this type of behaviour, rather than rely on the user not doing this.

I will admit that adding this is debatable and might not be what we want, but we should have a discussion at least.

MarvinJanssen commented 3 years ago

It turned out that the sender aggregated the transfers and combined two memo-less transactions before passing them to send-many-stx-cli. A non-empty memo could be enforced but it would not impact that particular issue.