search

hsu-hsu / nimble-survey-app

This is an application that allows users to browse a list of surveys.
0 stars 0 forks source link

[Bug] User can login with any combination of username/password #15

Closed minhnimble closed 8 months ago

minhnimble commented 8 months ago

Issue

When the user provides any combination of email and password (including invalid credentials), the app always sends the user to the Survey List screen.

Expect

There should be an error dialog to prevent the user to access the application.

Steps to reproduce

https://github.com/hsu-hsu/nimble-survey-app/assets/70877098/75e6b64a-351d-4627-9430-511553084478

hsu-hsu commented 8 months ago

In this pull request, I handle error response and show user with a toast. As for improvement, we can add validation in edittext. I will add this feature if I have extra time after solving other issues. pull request -> #24