search

hsu-hsu / nimble-survey-app

This is an application that allows users to browse a list of surveys.
0 stars 0 forks source link

[Bug] Some unit test cases are failing #16

Open minhnimble opened 8 months ago

minhnimble commented 8 months ago

Issue

It is quite nice to see that you've included a few unit tests for multiple View Models of the application. Unfortunately, there is a run test failed issue when I attempted to run them on my OnePlus N10 - Android 11 with the latest code at the commit 4d5c5cf95e75fee05d69b0b48fd7f627660047c5.

Here is the screenshot about the error issue:

Screenshot 2023-11-14 at 10 45 36

Expect

All tests should run successfully without any issue.

Step to reproduce

  1. Open the project.
  2. Right click on the unit tests folder and run them.
  3. Observe the result.
minhnimble commented 8 months ago

Also, there is no UI test provided in the application. It would be great if a few UI tests to verify some basic flows in the application could be provided (e.g., navigating the app from Login to Home screen, etc.)

hsu-hsu commented 8 months ago

I fix failing test in LoginViewModelTest in this pull request and I add some espresso tests for login screen. pull request -> #29

minhnimble commented 8 months ago

There was a test failed issue on your instrumented tests ⚠️

Screenshot 2023-11-16 at 23 09 53
hsu-hsu commented 8 months ago

I am sorry. I should check more carefully. When I tested I think it pass so I submitted it.😔