search

hsuanxyz / ion2-calendar

📅 A date picker components for ionic2 ／ionic3 / ionic4
https://hsuanxyz.github.io/demo/ion2-calendar/
MIT License
555 stars 278 forks source link

Calendar components do not apply custom colors. #183

Open fernandocode opened 6 years ago

fernandocode commented 6 years ago

Ionic version: (check one with "x") [ ] 2.x [x] 3.x [ ] 4.x

Ion2-calendar mode: (check one with "x") [x] components mode [x] modal mode

I'm submitting a ... (check one with "x") [x] bug report [ ] feature request [ ] help me

Current behavior:

Calendar components do not apply custom colors in variables.scss in the $colors variable.

Expected behavior:

The custom colors in variables.scss in the $colors variable should also be considered in the calendar components.

Steps to reproduce:

Create a new color in variables.scss in variavel$colors (... color_custom: #cccccc) and pass as parameter in calendar options the color created: color_custom, the highlighted items are colorless.

Related code:

It seems from what I could analyze that the creation of colors in the scss of the components are fixing only the default colors (primary, secondary, dark, ...).

alesrosina commented 5 years ago

I have also related issue, well described in this stackoverflow issue: https://stackoverflow.com/questions/47620090/ionic-3-invalid-css-value-in-variables-scss-file

If you use sth like:

$colors: (
  primary: (base: magenta, contrast: #fff),
  secondary: blue,
  custom_color: red
);

Then we would get error (base: magenta, contrast: #fff) isn't a valid CSS value.

If I remove this plugin, this SCSS works.

Any hints @hsuanxyz ?

GroupeBEL commented 4 years ago

Hi ,I have the same problem :( (ionic 5)