hsuanxyz / ion2-calendar

📅 A date picker components for ionic2 /ionic3 / ionic4
https://hsuanxyz.github.io/demo/ion2-calendar/
MIT License
555 stars 277 forks source link

'ionic-angular' not exist in Ionic 4 #249

Open andreagavioli opened 5 years ago

andreagavioli commented 5 years ago

Ionic version: (check one with "x") [ ] 2.x [ ] 3.x [ X ] 4.x

Ion2-calendar mode: (check one with "x") [ X ] components mode [ ] modal mode

I'm submitting a ... (check one with "x") [ X ] bug report [ ] feature request [ ] help me

Current behavior: [ng] ERROR in node_modules/ion2-calendar/dist/calendar.controller.d.ts(1,33): error TS2307: Cannot find module 'ionic-angular'. [ng] node_modules/ion2-calendar/dist/calendar.module.d.ts(2,33): error TS2307: Cannot find module 'ionic-angular'. [ng] node_modules/ion2-calendar/dist/components/calendar.modal.d.ts(2,68): error TS2307: Cannot find module 'ionic-angular'.

Expected behavior: Module should be updated with Ionic 4 equivalent new modules.

Steps to reproduce: Create a new Ionic 4 project Install ion2-calendar type "ionic serve"

Related code:

insert short code snippets here

Other information:

Ionic:

ionic (Ionic CLI) : 4.12.0 (C:\Users\Boogeyman\AppData\Roaming\npm\node_modules\ionic) Ionic Framework : @ionic/angular 4.4.2 @angular-devkit/build-angular : 0.13.9 @angular-devkit/schematics : 7.3.9 @angular/cli : 7.3.9 @ionic/angular-toolkit : 1.5.1

System:

NodeJS : v8.9.0 (C:\Program Files\nodejs\node.exe) npm : 6.9.0 OS : Windows 10

jefcoserrca commented 5 years ago

did you resolve the problem? i have the same problem, please tell me if you could resolve it.

vlasix commented 5 years ago

Same here.

bhandaribhumin commented 5 years ago

"ionic-angular": "3.9.5",

[13:48:56]  typescript: node_modules/ion2-calendar/dist/calendar.controller.d.ts, line: 1 
[app-scripts]             Cannot find module '@ionic/angular'. 
[app-scripts]        L1:  import { ModalController } from '@ionic/angular';
[app-scripts]        L2:  import { ModalOptions, CalendarModalOptions } from './calendar.model';
[app-scripts]             Cannot find module '@ionic/core'. 
[app-scripts] [13:48:56]  typescript: node_modules/ion2-calendar/dist/calendar.model.d.ts, line: 1 
[app-scripts]        L1:  import { AnimationBuilder } from '@ionic/core';
[app-scripts]        L2:  export interface CalendarOriginal {
[app-scripts]             Cannot find module '@ionic/angular'. 
[app-scripts] [13:48:56]  typescript: node_modules/ion2-calendar/dist/calendar.module.d.ts, line: 1 
[app-scripts]        L1:  import { ModalController } from '@ionic/angular';
[app-scripts]        L2:  import { CalendarController } from './calendar.controller';
[app-scripts]             Cannot find module '@ionic/angular'. 
[app-scripts] [13:48:56]  typescript: node_modules/ion2-calendar/dist/components/calendar.modal.d.ts, line: 2 
[app-scripts]        L1:  import { ElementRef, ChangeDetectorRef, Renderer2, OnInit, AfterViewInit } from '@angular/core';
[app-scripts]        L2:  import { NavParams, ModalController, IonContent } from '@ionic/angular';
[app-scripts]        L3:  import { CalendarDay, CalendarMonth, CalendarModalOptions } from '../calendar.model';
asd456680 commented 5 years ago

change 'ionic-angular' to '@ionic/angular'

ebhsgit commented 5 years ago

Seems like this pull request broke support for Ionic 3

200

It changed the ionic-angular dependency to @ionic/angular