hsuanyi-chou / shadcn-ui-expansions

More components built on top of shadcn-ui.
https://shadcnui-expansions.typeart.cc/
MIT License
1.1k stars 51 forks source link

Improve semantics of datetime-picker #130

Closed Poolshark closed 2 months ago

Poolshark commented 3 months ago

For people with stricter lint rules, I'd suggest the following updates in datetime-picker.ts:

netlify[bot] commented 3 months ago

Deploy Preview for shadcnui-expansions ready!

Name Link
Latest commit 979e092634bffae177a1efde7b477abfab8aa78e
Latest deploy log https://app.netlify.com/sites/shadcnui-expansions/deploys/66c3b275f741e10008f23739
Deploy Preview https://deploy-preview-130--shadcnui-expansions.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Poolshark commented 2 months ago

Not sure if this will still be merged. However, I have changed the initHourFormat function since in my opinion it does not make sense to show the full time format if the granularity parameter is set to minutes or hour.

hsuanyi-chou commented 2 months ago

Huge thanks!!!!