Closed sookach closed 2 weeks ago
Looks good, a regression test would be nice.
Looks good, a regression test would be nice.
Yeah, it passed on my fork https://github.com/sookach/cppfront/tree/pr/default_arg
but it looks like the tests don't run on their own in this repo?
but it looks like the tests don't run on their own in this repo?
https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks
By default, all first-time contributors require approval to run workflows.
Looks good, a regression test would be nice.
Yeah, it passed on my fork https://github.com/sookach/cppfront/tree/pr/default_arg
but it looks like the tests don't run on their own in this repo?
Ah, what I meant, is that it would be nice if you add a regression test for the new feature. Sorry for the misunderstanding.
Cool, added a regression test. Let me know what you think.
Thanks!
@hsutter @bluetarpmedia This patches #1090 by allowing defaulting of arguments in a function call by use of '()' (akin to '{}' in C++).