search

hsutter / cppfront

A personal experimental C++ Syntax 2 -> Syntax 1 compiler
Other
5.56k stars 248 forks source link

Exclude MSVC workaround on clang and gcc #1306

Closed gregmarr closed 1 month ago

gregmarr commented 1 month ago

Resolves #1304 On Windows, clang defines _MSC_VER, so the MSVC workaround needs to not happen when the clang define is set.

hsutter commented 1 month ago

Cool, I was just making the identical change (for __clang_major__ only) and running regressions when I saw this. If regressions pass I'll discard mine and merge this. Thanks!

hsutter commented 1 month ago

I think the one thing this PR doesn't do though is re-run regression tests... however I just did so I'll merge this and then separately merge the regression test outputs (which changed only because of cpp2util.h line numbers in error messages).

Thanks!

gregmarr commented 1 month ago

Weird that this would cause any line numbers to change unless there was a clang on Windows that is changing from the const line to the constexpr line.

Update: Looks like all those tests were already failing in main. The last time they passed was Aug 27th when #1250 was merged. https://github.com/hsutter/cppfront/actions/workflows/regression-tests.yml?page=2&query=branch%3Amain They started failing again with the next commit a minute later.