search

hsutter / cppfront

A personal experimental C++ Syntax 2 -> Syntax 1 compiler
Other
5.46k stars 238 forks source link

Fix: MSVC warning 5050 was not really suppressed #937

Closed adah1972 closed 8 months ago

adah1972 commented 8 months ago

The pragma should be put before the import, not after.

adah1972 commented 8 months ago

The warning still appeared when I issued the command line as follows:

cppfront -p demo.cpp2
cl /nologo /std:c++20 /EHsc /Iinclude /MD /experimental:module demo.cpp

The warning is now gone after the change.

hsutter commented 8 months ago

Thanks for your pull request! It looks like this may be your first contribution to cppfront. I've sent the Contributor License Agreement (CLA) to your email, and once it's signed I can look at your pull request. Thanks again for your contribution.

hsutter commented 8 months ago

Thanks!