hswolff / tree-view-extended

Atom.io package. Extend your tree-view. Add a list of open files, and a list of git modified files.
https://atom.io/packages/tree-view-extended
MIT License
8 stars 1 forks source link

Uncaught Error: Repository has been destroyed #5

Closed mattmeng closed 7 years ago

mattmeng commented 7 years ago

Steps to reproduce:

  1. Install tree-view-extended
  2. Switch to a window with code
  3. See the following Atom error message:

Atom: 1.14.4 x64 Electron: 1.3.13 OS: Ubuntu 16.04.2 Thrown From: tree-view-extended package 1.0.0

Stack Trace

Uncaught Error: Repository has been destroyed

At /usr/share/atom/resources/app.asar/src/git-repository.js:364

Error: Repository has been destroyed
    at GitRepository.module.exports.GitRepository.getRepo (/app.asar/src/git-repository.js:364:15)
    at GitRepository.module.exports.GitRepository.getPathStatus (/app.asar/src/git-repository.js:249:19)
    at GitRepository.module.exports.GitRepository.isPathModified (/app.asar/src/git-repository.js:222:41)
    at /packages/tree-view-extended/lib/extended-tree-view.js:94:26
    at Array.map (native)
    at ExtendedTreeView.render (/packages/tree-view-extended/lib/extended-tree-view.js:78:21)
    at ExtendedTreeView.setState (/packages/tree-view-extended/lib/extended-tree-view.js:42:10)
    at /packages/tree-view-extended/lib/open-files-pane-view.js:36:29
    at Function.module.exports.Emitter.simpleDispatch (/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/app.asar/node_modules/event-kit/lib/emitter.js:129:28)
    at stoppedChangingActivePaneItemCallback (/app.asar/src/pane-container.js:352:36)

Commands

     -3:34.7.0 command-palette:toggle (input.hidden-input)
 10x -3:28.8.0 core:move-down (input.hidden-input)
     -3:24.2.0 core:move-up (input.hidden-input)
     -3:23.7.0 core:move-down (input.hidden-input)
     -3:23.1.0 core:confirm (input.hidden-input)
     -3:23.1.0 tree-view-extended:show-all (input.hidden-input)
     -2:26.5.0 command-palette:toggle (input.hidden-input)
     -1:41.6.0 tree-view-extended:hide-git-modified-files (input.hidden-input)
     -0:43.3.0 settings-view:open (input.hidden-input)
     -0:34.6.0 core:confirm (input.hidden-input)
     -0:17 core:close (button.btn.icon.enablement.icon-playback-play)
     -0:12.4.0 project-manager:list-projects (input.hidden-input)
     -0:10.7.0 core:confirm (input.hidden-input)

Non-Core Packages

atom-increment 0.3.4 
file-watcher 1.0.3 
fonts 2.0.0 
git-diff-details 1.4.0 
git-plus 7.3.3 
highlight-selected 0.12.0 
language-docker 1.1.7 
language-pascal 0.20.2 
linter 1.11.23 
merge-conflicts 1.4.4 
minimap 4.26.8 
nord-atom-syntax 0.6.0 
nord-atom-ui 0.10.2 
pigments 0.39.0 
pretty-json 1.6.1 
project-manager 3.3.3 
rest-client 1.3.1 
seti-syntax 1.0.1 
seti-ui 1.6.1 
todo-show 1.11.0 
tree-view-extended 1.0.0 
mattmeng commented 7 years ago

The error is displayed every time I switch code files.

hswolff commented 7 years ago

That was a fun one to debug.

Fixed via https://github.com/hswolff/tree-view-extended/commit/ded3d91306b75698244d291c72b92be94d96299b

hswolff commented 7 years ago

(Also thanks for the report!)

mattmeng commented 7 years ago

Thank you for fixing it!