search

hsynnt / jarjar

Automatically exported from code.google.com/p/jarjar
0 stars 0 forks source link

index="true" doesn't work on jarjar ant task #4

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Set index="true" on a jarjar ant task

What is the expected output? What do you see instead?
I expect a valid INDEX.LIST however I get one containing only the jar name.
No packages.

What version of the product are you using? On what operating system?
Windows XP
Java 1.6.0_02
Ant 1.7.0
JarJar 1.0rc5

Please provide any additional information below.

Here's my task definition:

<jarjar jarfile="myjar.jar" index="true">
  <fileset dir="tmp" includes="somepackage/*.class/>
  <zipfileset src="lib/jartoinclude.jar"/>
  <rule pattern="org.apps.**" result="org.otherapps.@1"/>
</jarjar>

Original issue reported on code.google.com by henri.tr...@gmail.com on 5 Oct 2007 at 11:22

GoogleCodeExporter commented 8 years ago 
Just curious, what do you need the index for?

Original comment by chris.no...@gmail.com on 7 Feb 2008 at 1:33

GoogleCodeExporter commented 8 years ago 
No specific reason. I tend to put an index on my jars since it improves class 
loading
performances.

Original comment by henri.tr...@gmail.com on 7 Feb 2008 at 9:21

GoogleCodeExporter commented 8 years ago 
Here is a reason:
When converting a jar that has a index.list, and you do not specify 
index="true" the 
resulting jar will still have the original index.list, which doesn't match the 
reality anymore. Eclipse gives me a sun.misc.InvalidJarIndexException

Original comment by ffprobe...@dodgeit.com on 22 Jul 2008 at 8:42

GoogleCodeExporter commented 8 years ago 
It's true that the original jar index isn't valid anymore. However, I can't see 
why
it couldn't be regenerated with the final jarjared jar.

Original comment by henri.tr...@gmail.com on 22 Jul 2008 at 8:46

GoogleCodeExporter commented 8 years ago 
I agree, it must be regenerated.

Original comment by ffprobe...@dodgeit.com on 22 Jul 2008 at 10:07

GoogleCodeExporter commented 8 years ago 
This should be fixed in SVN head, let me know if it works for you.

Original comment by chris.no...@gmail.com on 30 Aug 2008 at 5:33

GoogleCodeExporter commented 8 years ago 
Works perfectly. Thanks!

Original comment by henri.tr...@gmail.com on 31 Aug 2008 at 12:14